contracts/ccip/ccip: validate account address lengths#220
Open
contracts/ccip/ccip: validate account address lengths#220
Conversation
JohnChangUK
had a problem deploying
to
integration
GitHub Actions
Failure
JohnChangUK
had a problem deploying
to
integration
GitHub Actions
Failure
JohnChangUK
reviewed
Jun 13, 2025
| pad_svm_address(&mut token_receiver); | ||
| assert!( | ||
| token_receiver.length() == 32, | ||
| error::invalid_argument(E_INVALID_SVM_TOKEN_RECEIVER_LENGTH) |
Contributor
There was a problem hiding this comment.
I prefer not to use these error::() wrappers as it makes writing test cases harder, as it will produce an erroneous error code which you have to convert from decimal to hex.
Collaborator
Author
There was a problem hiding this comment.
we are consistently using them across CCIP though
Contributor
There was a problem hiding this comment.
I see, we can keep this for now
JohnChangUK
approved these changes
Jun 13, 2025
Contributor
|
This PR is stale because it has been open days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.